Summary: | Selenium tests authentication.t does not remove all data it created | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, bouzid.fergani, hayleypelham, lucas |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
|
Circulation function: | |||
Bug Depends on: | 19181 | ||
Bug Blocks: | |||
Attachments: |
Bug 22860: Remove 1 remaining patron after authentication.t is ran
Bug 22860: Remove 1 remaining patron after authentication.t is ran Bug 22860: Remove 1 remaining patron after authentication.t is ran |
Description
Jonathan Druart
2019-05-06 20:37:35 UTC
Created attachment 89400 [details] [review] Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests I tried to test this, but was unable to replicate on master. Borrower count was 2, I ran prove t/db_dependent/selenium/authentication.t, then checked my borrower count again, and it was two. Have I missed a step here? Can you try that: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ git fetch origin kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ git checkout -B master origin/master kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ koha-mysql kohadev -e "select count(*) from borrowers;" +----------+ | count(*) | +----------+ | 99 | +----------+ kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/selenium/authentication.t t/db_dependent/selenium/authentication.t .. ok All tests successful. Files=1, Tests=2, 24 wallclock secs ( 0.02 usr 0.02 sys + 2.07 cusr 0.76 csys = 2.87 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ koha-mysql kohadev -e "select count(*) from borrowers;" +----------+ | count(*) | +----------+ | 100 | +----------+ The selenium server must have been started before (in a devbox you can use the `start_selenium` alias) Created attachment 97771 [details] [review] Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Hi, I can't reproduce this issue in the updated master mysql> select count(*) from borrowers; +----------+ | count(*) | +----------+ | 68379 | +----------+ prove t/db_dependent/selenium/authentication.t t/db_dependent/selenium/authentication.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.68 cusr 0.11 csys = 1.81 CPU) Result: PASS mysql> select count(*) from borrowers; +----------+ | count(*) | +----------+ | 68379 | +----------+ You can check this please. Thanks. Bouzid. I can replicate the issue on master - trying the fix next. Created attachment 98615 [details] [review] Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.04 backported to 19.05.x for 19.05.09 |