| Summary: | Cannot add a patron card layout with mysql strict mode on | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Liz Rea <wizzyrea> | 
| Component: | Label/patron card printing | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, martin.renvoize, nick, wizzyrea | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Small patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       19.05.00, 18.11.06 
 | 
        
        Circulation function: | |
| Bug Depends on: | |||
| Bug Blocks: | 17258 | ||
| Attachments: | 
              Bug 22878: Add tests
               Bug 22878: Do not pass layout_id on creating a layout Bug 22878: Add tests Bug 22878: Do not pass layout_id on creating a layout Bug 22878: Add tests Bug 22878: Do not pass layout_id on creating a layout  | 
      ||
| 
 
        
          Description
        
        
          Liz Rea
        
        
        
        
          2019-05-09 14:49:51 UTC
        
       
    Created attachment 89562 [details] [review] Bug 22878: Add tests Created attachment 89563 [details] [review] Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Created attachment 89575 [details] [review] Bug 22878: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 89576 [details] [review] Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 89594 [details] [review] Bug 22878: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89595 [details] [review] Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.06 Pushed to 18.05 for 18.05.14  |