| Summary: | Use DataTables for Koha news table filtering | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Tools | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, maryse.simard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 22811 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22888: Use DataTables for Koha news table filtering
Bug 22888: Use DataTables for Koha news table filtering Bug 22888: Use DataTables for Koha news table filtering |
||
|
Description
Owen Leonard
2019-05-10 16:03:51 UTC
Created attachment 89658 [details] [review] Bug 22888: Use DataTables for Koha news table filtering This patch modifies the Koha news page so that filtering the table of news is done using DataTables' built-in search functionality. This allows for the table to be filtered without requiring a reload of the page. The patch also moves the table filter into a sidebar form and adds a keyword field. A minor change has been made to the global CSS to improve the display of the form in the sidebar. To test, apply the patch and rebuild the staff client CSS. - Go to Tools -> News. - Test the various table filter options: keyword, display location, and library. Confirm that all work as expected. - Changes to the keyword search text should be reflected in the search field at the top of the table, and vice versa. - Changes to the sidebar filter should trigger the correct state of the "Clear filter" button at the top of the news table (enabled or disabled). Created attachment 90084 [details] [review] Bug 22888: Use DataTables for Koha news table filtering This patch modifies the Koha news page so that filtering the table of news is done using DataTables' built-in search functionality. This allows for the table to be filtered without requiring a reload of the page. The patch also moves the table filter into a sidebar form and adds a keyword field. A minor change has been made to the global CSS to improve the display of the form in the sidebar. To test, apply the patch and rebuild the staff client CSS. - Go to Tools -> News. - Test the various table filter options: keyword, display location, and library. Confirm that all work as expected. - Changes to the keyword search text should be reflected in the search field at the top of the table, and vice versa. - Changes to the sidebar filter should trigger the correct state of the "Clear filter" button at the top of the news table (enabled or disabled). Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 90135 [details] [review] Bug 22888: Use DataTables for Koha news table filtering This patch modifies the Koha news page so that filtering the table of news is done using DataTables' built-in search functionality. This allows for the table to be filtered without requiring a reload of the page. The patch also moves the table filter into a sidebar form and adds a keyword field. A minor change has been made to the global CSS to improve the display of the form in the sidebar. To test, apply the patch and rebuild the staff client CSS. - Go to Tools -> News. - Test the various table filter options: keyword, display location, and library. Confirm that all work as expected. - Changes to the keyword search text should be reflected in the search field at the top of the table, and vice versa. - Changes to the sidebar filter should trigger the correct state of the "Clear filter" button at the top of the news table (enabled or disabled). Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This works well and is a nice enhancement, just one thing: I am not sure if it's not a little confusing to have 2 keyword search options available that fill out the other, when typing in it. It's a new pattern at least :) Nice work! Pushed to master for 19.11.00 (In reply to Katrin Fischer from comment #4) > This works well and is a nice enhancement, just one thing: I am not sure if > it's not a little confusing to have 2 keyword search options available that > fill out the other, when typing in it. It's a new pattern at least :) I agree.. this feels a little odd but I'm not entirely sure how to tidy it up.. Lets handle it on it's own bug perhaps. Enhancement not pushed to 19.05.x |