Summary: | contributors.yaml not correctly copied | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | martin.renvoize, mirko, nick, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Circulation function: | |||
Bug Depends on: | 21662 | ||
Bug Blocks: | 21626 | ||
Attachments: |
Bug 22893: Do not crash if contributors.yaml does not exist
Bug 22893: Embed contributors.yaml for debian packages Bug 22893: Do not crash if contributors.yaml does not exist Bug 22893: Embed contributors.yaml for debian packages Bug 22893: Do not crash if contributors.yaml does not exist Bug 22893: Embed contributors.yaml for debian packages |
Description
Jonathan Druart
2019-05-12 17:50:43 UTC
Tomas, do you agree? Something else I have missed? (In reply to Jonathan Druart from comment #1) > Tomas, do you agree? Something else I have missed? 100% correct Created attachment 89644 [details] [review] Bug 22893: Do not crash if contributors.yaml does not exist Created attachment 89645 [details] [review] Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL) I'd suggest 2 QA reviews and let jenkins test this patch. Unless someone wants to build a package and test the debian upgrade process. (In reply to Jonathan Druart from comment #5) > I'd suggest 2 QA reviews and let jenkins test this patch. Unless someone > wants to build a package and test the debian upgrade process. I will build it tomorrow morning. Ack, good catch.. can't believe I missed this during creating the original patchset. Created attachment 89746 [details] [review] Bug 22893: Do not crash if contributors.yaml does not exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 89747 [details] [review] Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I was building packages this morning anyway so threw this into the mix. Worked for me using the procedure in 'building packages the easy way'. Signing off. Created attachment 89761 [details] [review] Bug 22893: Do not crash if contributors.yaml does not exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 89762 [details] [review] Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested it using koha/koha-dpkg:master, everything went smooth. Good job Joubu Awesome work all! Pushed to master for 19.05 Bug not in 18.11.x series. |