Bug 22915

Hey Martin - I just tried this out and it worked for me.  I did not receive that message.

Looks ok for me as well, however on the confirmation screen, I get:

Following information will be registered:
First Name:
Last Name:
E-Mail: 

(all empty)

https://ui.mana-kb.koha-community.org/registration?id=XXX


Then I confirm and get:

Error: seems like the token you try to activate (XXX) doesn't exist or is to old

Hi Jonathan, that's the same I got when testing bug 22210. Did you change your settings to test with the production server?

(In reply to Katrin Fischer from comment #3)
> Hi Jonathan, that's the same I got when testing bug 22210. Did you change
> your settings to test with the production server?

Nope, I was expecting prod and test to behave identically :)

(In reply to Jonathan Druart from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Hi Jonathan, that's the same I got when testing bug 22210. Did you change
> > your settings to test with the production server?
> 
> Nope, I was expecting prod and test to behave identically :)

They don't because of the organisational sign-up bug 22210.

Regarding the "token does not exist" comment : 
The problem probably comes from the production & test server : until recently there was only one, even we the 2 URLs existed.
We've splitted them when the patch has been pushed. Thus, a token created on prod is no more known by test (and vice-versa). I'll ask Alex to have a look at it asap (he's in holiday for now)
Regarding the initial description, sorry martin, no idea :(

Perhaps I happened to hit the feature when the Mana server was down or something?

Created attachment 90304 [details]
Error

Afraid I do still see this error.. attaching a screenshot

(In reply to Martin Renvoize from comment #8)
> Created attachment 90304 [details]
> Error
> 
> Afraid I do still see this error.. attaching a screenshot

Martin,

URL is https://mana-kb... Not http://mana-kb.
switching to https should solve your problem.

(In reply to Jonathan Druart from comment #2)
> Looks ok for me as well, however on the confirmation screen, I get:
> 
> Following information will be registered:
> First Name:
> Last Name:
> E-Mail: 
> 
> (all empty)
> 
> https://ui.mana-kb.koha-community.org/registration?id=XXX
> 
> 
> Then I confirm and get:
> 
> Error: seems like the token you try to activate (XXX) doesn't exist or is to
> old

All ok for me.
Nothing empty and i get this confirmation message:
"E-mail successfuly validated, token xxxx is now active."

(on production server)

(In reply to Alex Arnaud from comment #10)
> (In reply to Jonathan Druart from comment #2)
> > Looks ok for me as well, however on the confirmation screen, I get:
> > 
> > Following information will be registered:
> > First Name:
> > Last Name:
> > E-Mail: 
> > 
> > (all empty)
> > 
> > https://ui.mana-kb.koha-community.org/registration?id=XXX
> > 
> > 
> > Then I confirm and get:
> > 
> > Error: seems like the token you try to activate (XXX) doesn't exist or is to
> > old
> 
> All ok for me.
> Nothing empty and i get this confirmation message:
> "E-mail successfuly validated, token xxxx is now active."
> 
> (on production server)

I got it!

Mana test server was set up with production URL. So you was registering on test and try to confirm it on production one (thx Katrin for the catch).

Aha, excellent.. it sounds like you found the issue.. I'll have a quick test and report back.

Right.. so it does work now as long as I change koha-conf to point to the https URL.

However.. I do still think there's a couple of bugs here.

Firstly: looking at master, 'etc/koha-conf.xml' which is used as part of the make process still points to 'http' so by default people using the make process to install will be getting an incorrect default config.

Secondly: The error here is meaningless.. we should be able to catch a bad URL earlier and give a much more meaningful error.. I wasn't sure whether it was the Mana service that was down, a Koha end bug or what.

Is there a reason we have the URL in koha-conf.xml? It might be nice to store it in a pref. But I might be missing something.

Created attachment 90409 [details] [review]
Bug 22915: fix Mana URL in etc/koha-conf.xml

(In reply to Katrin Fischer from comment #14)
> Is there a reason we have the URL in koha-conf.xml? It might be nice to
> store it in a pref. But I might be missing something.

1) IMO for consistency. All external backends/services URI are defined in koha-conf.xml (elasticsearch, pazpar2 etc...).

2) To prevent an other system preference :)

(In reply to Martin Renvoize from comment #13)
> Right.. so it does work now as long as I change koha-conf to point to the
> https URL.
> 
> However.. I do still think there's a couple of bugs here.
> 
> Firstly: looking at master, 'etc/koha-conf.xml' which is used as part of the
> make process still points to 'http' so by default people using the make
> process to install will be getting an incorrect default config.
Fixed in the attached patch
> 
> Secondly: The error here is meaningless.. we should be able to catch a bad
> URL earlier and give a much more meaningful error.. I wasn't sure whether it
> was the Mana service that was down, a Koha end bug or what.
Not a blocker for me. This can be done in a separate BZ

Thanks Alex, 

I'm game with that, the /etc/ fix is nice to have here and I'm not worried about it staying in koha-conf for now... (if we do end up with lots of mana servers hosted by the various support companies, my opinion on it being converted to a pref may change).

Also happy to have a nicer fix for the error message done in a distinct bug.

As a string patch I'm going to go straight for PQA here and push it :)

Created attachment 90410 [details] [review]
Bug 22915: fix Mana URL in etc/koha-conf.xml

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Nice work!

Pushed to master for 19.11.00

Pushed to 19.05.x for 19.05.01