Summary: | Enabling the GDPR_Policy will affect libraries using the SCO module in Koha | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Self checkout | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, lucas, m.de.rooy, tomascohen |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
Circulation function: | |||
Attachments: |
Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy
Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy |
Description
Kelly McElligott
2019-05-16 15:32:40 UTC
Created attachment 89881 [details] [review] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 92638 [details] [review] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 92652 [details] [review] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Tomás Cohen Arazi from comment #3) > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Thanks Kyle and Tomas ! Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 backported to 18.11.x for 18.11.11 |