Bug 22934

Summary: Add missing use statement to Koha::AdditionalFieldValue
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: SerialsAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: colin.campbell, m.de.rooy, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 15774    
Bug Blocks: 22932    
Attachments: Bug 22934: Add missing use statement
Bug 22934: Add missing use statement
Bug 22934: Add missing use statement
Bug 22934: Add missing use statement

Description Nick Clemens (kidclamp) 2019-05-17 12:29:56 UTC
When refactoring additional fields for 15774 it looks like a use statement was missed
Comment 1 Nick Clemens (kidclamp) 2019-05-17 12:32:26 UTC
Created attachment 89893 [details] [review]
Bug 22934: Add missing use statement

Also fixes a typo

To test:
1 - Add a subscription to a record
2 - Add an additional field in the admin section
3 - Edit the subscription and define the additional field
4 - Ensure you can view the record in the staff client and opac
Comment 2 Owen Leonard 2019-05-17 12:40:18 UTC
Created attachment 89895 [details] [review]
Bug 22934: Add missing use statement

Also fixes a typo

To test:
1 - Add a subscription to a record
2 - Add an additional field in the admin section
3 - Edit the subscription and define the additional field
4 - Ensure you can view the record in the staff client and opac

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Bin Wen 2019-05-17 19:27:06 UTC
Created attachment 89919 [details] [review]
Bug 22934: Add missing use statement

Also fixes a typo

To test:
1 - Add a subscription to a record
2 - Add an additional field in the admin section
3 - Edit the subscription and define the additional field
4 - Ensure you can view the record in the staff client and opac
5 - Without patch ,in the subscription detail page,click the link of the record title. => software error.
6 - Apply the patch. => no error anymore.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Comment 4 Marcel de Rooy 2019-05-22 14:37:03 UTC
Created attachment 89960 [details] [review]
Bug 22934: Add missing use statement

Also fixes a typo

To test:
1 - Add a subscription to a record
2 - Add an additional field in the admin section
3 - Edit the subscription and define the additional field
4 - Ensure you can view the record in the staff client and opac
5 - Without patch ,in the subscription detail page,click the link of the record title. => software error.
6 - Apply the patch. => no error anymore.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Fixed another typo on L21
Comment 5 Nick Clemens (kidclamp) 2019-05-23 15:02:05 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize (ashimema) 2019-05-30 19:43:22 UTC
Bug with new feature not in 18.11.x series