| Summary: | Searching by library groups uses group Title rather than Description | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lisette Scheer <lisettepalouse+koha> |
| Component: | Searching | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, kyle, lisettepalouse+koha, lucas |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 22937: Display library search group descriptions
Bug 22937: Display library search group descriptions Bug 22937: Add hint to groups editor Bug 22937: Add hint to groups editor Bug 22937: Add hint to groups editor Bug 22937: Add hint to groups editor |
||
|
Description
Lisette Scheer
2019-05-17 17:03:19 UTC
Created attachment 90442 [details] [review] Bug 22937: Display library search group descriptions Instead of their "title" Test plan: Create a group of library with a title and a description On the advanced search pages (OPAC & staff) confirm the the description is displayed Edit the group of library and remove its description The "title" must now be displayed Created attachment 90448 [details] [review] Bug 22937: Display library search group descriptions Instead of their "title" Test plan: Create a group of library with a title and a description On the advanced search pages (OPAC & staff) confirm the the description is displayed Edit the group of library and remove its description The "title" must now be displayed Signed-off-by: David Nind <david@davidnind.com> I am not sure if this is a bug or a case of 'needs better labelling'. While we use internal codes for things like libraries/branches and itemtypes that we enter in the GUI, the library groups feature uses a numeric primary key. Unlike a code, the title shown in the GUI can be changed anytime and I think is supposed to be the display text, while the description can be used to give more information to staff. Example how I'd use it: Title: South Germany Description: Grouping all branches in Bavaria and BW into a hold group. I think if we changed this now, libraries who used it like this won't be happy. Adding Kyle for another opinion. that is a (In reply to Katrin Fischer from comment #3) > I am not sure if this is a bug or a case of 'needs better labelling'. > I think probably it needs better labeling. I can definitely see how people have used descriptions differently. When BWS set up our groups when the feature was added our descriptions were very similar to our titles. Lisette Created attachment 102012 [details] [review] Bug 22937: Add hint to groups editor It should be <div class="hint"> instead of <span> :) The hint only shows when you are editing an existing group, not when creating a group. Lisette Created attachment 102512 [details] [review] Bug 22937: Add hint to groups editor Created attachment 102522 [details] [review] Bug 22937: Add hint to groups editor Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 102541 [details] [review] Bug 22937: Add hint to groups editor Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |