| Summary: | Markup error in OPAC search results around lists display | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.01
|
|
| Circulation function: | |||
| Attachments: |
Bug 22945: Markup error in OPAC search results around lists display
Eliminates both error messages. Looks good, thanks Owen. Bug 22945: Markup error in OPAC search results around lists display |
||
|
Description
Owen Leonard
2019-05-21 12:08:43 UTC
Created attachment 89934 [details] [review] Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Created attachment 90634 [details] [review] Eliminates both error messages. Looks good, thanks Owen. Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 90698 [details] [review] Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.01 |