| Summary: | Markup error in OPAC search results around selection links | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy, mtompset, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.02
|
|
| Circulation function: | |||
| Attachments: |
Bug 22946: Markup error in OPAC search results around selection links
Bug 22946: Markup error in OPAC search results around selection links Bug 22946: Markup error in OPAC search results around selection links |
||
|
Description
Owen Leonard
2019-05-21 12:23:25 UTC
Created attachment 89942 [details] [review] Bug 22946: Markup error in OPAC search results around selection links This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, make sure holds and/or tags are enabled in the OPAC. Perform a search in the OPAC which will return multiple results. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "Element div not allowed as child of element span in this context." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Had to TagsInputOnList 'Allow'. Created attachment 90867 [details] [review] Bug 22946: Markup error in OPAC search results around selection links This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, make sure holds and/or tags are enabled in the OPAC. Perform a search in the OPAC which will return multiple results. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "Element div not allowed as child of element span in this context." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> This fixes the two div errors, as expected. Created attachment 90888 [details] [review] Bug 22946: Markup error in OPAC search results around selection links This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, make sure holds and/or tags are enabled in the OPAC. Perform a search in the OPAC which will return multiple results. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "Element div not allowed as child of element span in this context." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.02 backported to 18.11.x for 18.11.08 |