Bug 22948

Summary:	Markup error in OPAC bibliographic detail template
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, lucas, maryse.simard
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.11.00,19.05.01
Circulation function:
Attachments:	Bug 22948: Markup error in OPAC bibliographic detail template Bug 22948: Markup error in OPAC bibliographic detail template Bug 22948: Markup error in OPAC bibliographic detail template Bug 22948: Markup error in OPAC bibliographic detail template

Description Owen Leonard 2019-05-21 14:26:49 UTC

There are quite a few validation errors coming from the OPAC detail template (opac-detail.tt), but I would like to address one with this patch:


 - "The aria-labelledby attribute must point to an element in the same document."

Comment 1 Owen Leonard 2019-05-21 14:34:55 UTC

Created attachment 89943 [details] [review]
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Comment 2 Maryse Simard 2019-05-31 19:11:21 UTC

Created attachment 90248 [details] [review]
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Comment 3 Bin Wen 2019-05-31 19:53:12 UTC

Created attachment 90257 [details] [review]
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Comment 4 Katrin Fischer 2019-06-02 13:32:53 UTC

Created attachment 90266 [details] [review]
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Katrin Fischer 2019-06-02 13:33:27 UTC

Maybe something for another day/bug:

 FAIL	koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
   OK	  filters
   FAIL	  forbidden patterns
		forbidden paattern: Contains old bootstrap style for buttons (see bug 16239) (line 93)

Comment 6 Martin Renvoize (ashimema) 2019-06-04 09:20:08 UTC

Nice work!

Pushed to master for 19.11.00

Comment 7 Fridolin Somers 2019-06-10 14:56:35 UTC

Pushed to 19.05.x for 19.05.01

Comment 8 Lucas Gass (lukeg) 2019-06-11 16:37:43 UTC

backported to 18.11.x for 18.11.07