Bug 22958

Summary:	The Help link on SMS providers page should link to the correct chapter in the manual
Product:	Koha	Reporter:	Kelly McElligott <kelly>
Component:	Staff interface	Assignee:	Katrin Fischer <katrin.fischer>
Status:	CLOSED FIXED	QA Contact:	Josef Moravec <josef.moravec>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, josef.moravec, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.11.00,19.05.01
Circulation function:
Attachments:	Bug 22958: Fix help link on the SMS providers page Bug 22958: Fix help link on the SMS providers page Bug 22958: Fix help link on the SMS providers page

Description Kelly McElligott 2019-05-21 23:52:02 UTC

With the introduction of the new help button opening up the manual in Koha 18.11, clicking on Help when in the SMS set up in the administration module does not bring the user to that portion of the manual, instead it goes to the main page of the manual.

It should go here 

https://koha-community.org/manual/18.11/en/html/administration.html#sms-cellular-providers

Comment 1 Katrin Fischer 2019-06-02 09:02:22 UTC

Created attachment 90264 [details] [review]
Bug 22958: Fix help link on the SMS providers page

The help link on the SMS providers page didn't link to the
according chapter in the manual.

To test:
- Enter Email in SMSSendDriver system preference to
  make the configuration page appear
- Go to Administration > SMS cellular providers
- Click on the help link
- Verify it leads to the manual start page
- Apply patch
- Repeat and verify the link now leads to the correct
  section in the manual

Comment 2 Liz Rea 2019-06-03 15:32:35 UTC

Created attachment 90274 [details] [review]
Bug 22958: Fix help link on the SMS providers page

The help link on the SMS providers page didn't link to the
according chapter in the manual.

To test:
- Enter Email in SMSSendDriver system preference to
  make the configuration page appear
- Go to Administration > SMS cellular providers
- Click on the help link
- Verify it leads to the manual start page
- Apply patch
- Repeat and verify the link now leads to the correct
  section in the manual

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Comment 3 Josef Moravec 2019-06-05 15:55:10 UTC

Created attachment 90340 [details] [review]
Bug 22958: Fix help link on the SMS providers page

The help link on the SMS providers page didn't link to the
according chapter in the manual.

To test:
- Enter Email in SMSSendDriver system preference to
  make the configuration page appear
- Go to Administration > SMS cellular providers
- Click on the help link
- Verify it leads to the manual start page
- Apply patch
- Repeat and verify the link now leads to the correct
  section in the manual

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Comment 4 Martin Renvoize (ashimema) 2019-06-06 14:27:56 UTC

Nice work!

Pushed to master for 19.11.00

Comment 5 Fridolin Somers 2019-06-11 13:49:39 UTC

Pushed to 19.05.x for 19.05.01

Comment 6 Lucas Gass (lukeg) 2019-06-12 22:14:31 UTC

backported to 18.11.x for 18.11.07