|
Description
Héctor Eduardo Castro Avalos
2019-05-22 06:40:36 UTC
Created attachment 89955 [details] [review] Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Created attachment 90072 [details] [review] Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 90121 [details] [review] Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 90122 [details] [review] Bug 22960: Fix the same typo on db level for existing and new installations Seriously trying to kill the typo everywhere: - Check your DB with a report: select * from systempreferences where variable = 'UpdateItemLocationOnCheckin'; - Verify the typo in the explanation column: locaiton - Apply patch and run database update - Verify the typo is fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I think I went a little far with the follow-up... someone minding giving it a sign-off? Created attachment 90138 [details] [review] Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 90140 [details] [review] Bug 22960: Fix the same typo on db level for existing and new installations Seriously trying to kill the typo everywhere: - Check your DB with a report: select * from systempreferences where variable = 'UpdateItemLocationOnCheckin'; - Verify the typo in the explanation column: locaiton - Apply patch and run database update - Verify the typo is fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Thanks Josef! Created attachment 90265 [details] [review] Bug 22960: (follow-up) Fix another tiny typo This only seems to appear in the .pref file: ...pairs. the => ... pairs. The Nice work! Pushed to master for 19.11.00 Created attachment 90306 [details] [review] Bug 22960: (RM follow-up) Correct a further typo "This a list" changed to "This is a list" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to 19.05.x for 19.05.01 |