| Summary: | Remove type attribute from script tags: Acquisitions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | nick, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Small patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | |||
| Bug Blocks: | 22956 | ||
| Attachments: |
Bug 22975: Remove type attribute from script tags: Acquisitions
Bug 22975: Remove type attribute from script tags: Acquisitions Bug 22975: Remove type attribute from script tags: Acquisitions |
||
|
Description
Owen Leonard
2019-05-23 13:46:30 UTC
Created attachment 90039 [details] [review] Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Created attachment 90056 [details] [review] Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 90125 [details] [review] Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 |