Bug 22979

Summary: Remove type attribute from script tags: Authorities
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: nick, testopia
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 22956    
Attachments: Bug 22979: Remove type attribute from script tags: Authorities
Bug 22979: Remove type attribute from script tags: Authorities
Bug 22979: Remove type attribute from script tags: Authorities

Description Owen Leonard 2019-05-23 15:49:41 UTC
This patch will remove the obsolete "type" attribute from <script> tags in the following authorities templates:

 - intranet-tmpl\prog\en\modules\authorities\auth_finder.tt
 - intranet-tmpl\prog\en\modules\authorities\authorities.tt
 - intranet-tmpl\prog\en\modules\authorities\blinddetail-biblio-search.tt
 - intranet-tmpl\prog\en\modules\authorities\detail.tt
 - intranet-tmpl\prog\en\modules\authorities\searchresultlist-auth.tt
Comment 1 Owen Leonard 2019-05-23 17:45:51 UTC Comment hidden (obsolete)
Comment 2 Hayley Pelham 2019-05-23 23:27:53 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2019-05-27 20:52:22 UTC
Created attachment 90126 [details] [review]
Bug 22979: Remove type attribute from script tags: Authorities

This patch removes the "type" attribute from <script> tags in several
authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Authorities -> Search -> View authority record
 - Authorities -> Search -> Edit authority record
 - Cataloging -> New record
   - Trigger the authority search form by clicking the plugin link next
     to a tag which has been linked to an authority type (e.g. 100a ->
     Personal name).
   - Search for an authority record.
   - Select an authority record.

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=22797
Comment 4 Nick Clemens 2019-05-30 10:40:07 UTC
Awesome work all!

Pushed to master for 19.05