| Summary: | Remove type attribute from script tags: Authorities | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | nick, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22956 | ||
| Attachments: |
Bug 22979: Remove type attribute from script tags: Authorities
Bug 22979: Remove type attribute from script tags: Authorities Bug 22979: Remove type attribute from script tags: Authorities |
||
|
Description
Owen Leonard
2019-05-23 15:49:41 UTC
Created attachment 90045 [details] [review] Bug 22979: Remove type attribute from script tags: Authorities This patch removes the "type" attribute from <script> tags in several authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Authorities -> Search -> View authority record - Authorities -> Search -> Edit authority record - Cataloging -> New record - Trigger the authority search form by clicking the plugin link next to a tag which has been linked to an authority type (e.g. 100a -> Personal name). - Search for an authority record. - Select an authority record. Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Created attachment 90057 [details] [review] Bug 22979: Remove type attribute from script tags: Authorities This patch removes the "type" attribute from <script> tags in several authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Authorities -> Search -> View authority record - Authorities -> Search -> Edit authority record - Cataloging -> New record - Trigger the authority search form by clicking the plugin link next to a tag which has been linked to an authority type (e.g. 100a -> Personal name). - Search for an authority record. - Select an authority record. Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 90126 [details] [review] Bug 22979: Remove type attribute from script tags: Authorities This patch removes the "type" attribute from <script> tags in several authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Authorities -> Search -> View authority record - Authorities -> Search -> Edit authority record - Cataloging -> New record - Trigger the authority search form by clicking the plugin link next to a tag which has been linked to an authority type (e.g. 100a -> Personal name). - Search for an authority record. - Select an authority record. Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=22797 Awesome work all! Pushed to master for 19.05 |