Summary: | Remove type attribute from script tags: Catalog | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | nick |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 22956 | ||
Attachments: |
Bug 22981: Remove type attribute from script tags: Catalog
Bug 22981: Remove type attribute from script tags: Catalog Bug 22981: Remove type attribute from script tags: Catalog |
Description
Owen Leonard
2019-05-23 17:53:28 UTC
Created attachment 90049 [details] [review] Bug 22981: Remove type attribute from script tags: Catalog This patch removes the "type" attribute from <script> tags in several catalog-related templates. To test, apply the patch and confirm that the following work properly without any JavaScript errors in the browser console: - Catalog -> Advanced search - Catalog -> Item search - Search history Validating the HTML source of these pages should return no errors related to the "type" attribute. Created attachment 90058 [details] [review] Bug 22981: Remove type attribute from script tags: Catalog This patch removes the "type" attribute from <script> tags in several catalog-related templates. To test, apply the patch and confirm that the following work properly without any JavaScript errors in the browser console: - Catalog -> Advanced search - Catalog -> Item search - Search history Validating the HTML source of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 90127 [details] [review] Bug 22981: Remove type attribute from script tags: Catalog This patch removes the "type" attribute from <script> tags in several catalog-related templates. To test, apply the patch and confirm that the following work properly without any JavaScript errors in the browser console: - Catalog -> Advanced search - Catalog -> Item search - Search history Validating the HTML source of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 |