Summary: | When you merge records in a list there is no way to return to the list | ||
---|---|---|---|
Product: | Koha | Reporter: | axel Amghar <axel.amghar> |
Component: | Lists | Assignee: | axel Amghar <axel.amghar> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | m.de.rooy, severine.queune |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 22992: Ability to return to the list when you merge records of a list
Bug 22992: Ability to return to the list when you merge records of a list Bug 22992: Ability to return to the list when you merge records of a list |
Description
axel Amghar
2019-05-27 12:28:17 UTC
Created attachment 90145 [details] [review] Bug 22992: Ability to return to the list when you merge records of a list Test plan: Without the patch : - Create 2 records - Add them to the same list - Go to the list and merge these two patrons - In the nav bar you can't go back to the list Apply the patch - Now you should have a nav bar to return to the list like that :https://snag.gy/cnWxa2.jpg - Test every link of the nav bar, they should work - Make all the merge process, and test the links on the 3 pages I see one very small issue: This breadcrumb link: Contents of <i>[% shelf.name | uri %]</i> ...that should use the "html" filter instead of "uri" Created attachment 90175 [details] [review] Bug 22992: Ability to return to the list when you merge records of a list Test plan: Without the patch : - Create 2 records - Add them to the same list - Go to the list and merge these two patrons - In the nav bar you can't go back to the list Apply the patch - Now you should have a nav bar to return to the list like that :https://snag.gy/cnWxa2.jpg - Test every link of the nav bar, they should work - Make all the merge process, and test the links on the 3 pages Created attachment 90183 [details] [review] Bug 22992: Ability to return to the list when you merge records of a list Test plan: Without the patch : - Create 2 records - Add them to the same list - Go to the list and merge these two patrons - In the nav bar you can't go back to the list Apply the patch - Now you should have a nav bar to return to the list like that :https://snag.gy/cnWxa2.jpg - Test every link of the nav bar, they should work - Make all the merge process, and test the links on the 3 pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Hello, I just realized i wrote (in the test plan): "Go to the list and merge these two patrons" but i mean "Go to the list and merge these two RECORDS" sorry for the mistake + %shelf = ( + private => $input->param("shelf_private"), + name => $input->param("shelfname"), + number => $input->param("shelfnumber") + ); Axel, Thanks for your patch! I would recommend to pass only the shelfnumber via a CGI parameter in the URL. And get the Koha object for it in the script. This allows you to better check what you receive. The other parameters could be misused when mangling URLs. |