Bug 23027

Summary: Suggestions.t is failing if no biblio in DB
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, josef.moravec
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.01
Attachments: Bug 23027: Make Suggestions.t pass even if no biblio in DB
Bug 23027: Make Suggestions.t pass even if no biblio in DB
Bug 23027: Make Suggestions.t pass even if no biblio in DB

Comment 1 Jonathan Druart 2019-05-31 16:42:53 UTC
Created attachment 90236 [details] [review]
Bug 23027: Make Suggestions.t pass even if no biblio in DB

There are biblionumbers 1 and 2 hardcoded

Test plan:
MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio;
% prove t/db_dependent/Suggestions.t
Must return green with this patch applied
Comment 2 Liz Rea 2019-06-03 15:56:28 UTC
Created attachment 90276 [details] [review]
Bug 23027: Make Suggestions.t pass even if no biblio in DB

There are biblionumbers 1 and 2 hardcoded

Test plan:
MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio;
% prove t/db_dependent/Suggestions.t
Must return green with this patch applied

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 3 Josef Moravec 2019-06-05 15:40:18 UTC
Created attachment 90338 [details] [review]
Bug 23027: Make Suggestions.t pass even if no biblio in DB

There are biblionumbers 1 and 2 hardcoded

Test plan:
MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio;
% prove t/db_dependent/Suggestions.t
Must return green with this patch applied

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Josef Moravec 2019-06-05 15:40:47 UTC
Good catch Jonathan
Comment 5 Martin Renvoize 2019-06-06 14:28:00 UTC
Nice work!

Pushed to master for 19.11.00
Comment 6 Fridolin Somers 2019-06-11 13:48:33 UTC
Pushed to 19.05.x for 19.05.01