Summary: | Error during upgrade of OpacNavRight preference to Koha news | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | critical | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
19.11.00,19.05.01
|
Circulation function: | |
Bug Depends on: | 22318 | ||
Bug Blocks: | |||
Attachments: |
Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight
Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight |
Description
Owen Leonard
2019-06-11 12:39:41 UTC
Created attachment 90494 [details] [review] Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news Created attachment 90500 [details] [review] Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 90531 [details] [review] Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.01 |