| Summary: | KOC upload process has misleading wording | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Benjamin Daeuber <bdaeuber> |
| Component: | Circulation | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, lisettepalouse+koha, lucas, mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Attachments: |
Bug 23098: Reword success message of KOC upload process
Bug 23098: Reword success message of KOC upload process Bug 23098: Reword success message of KOC upload process |
||
|
Description
Benjamin Daeuber
2019-06-11 17:06:04 UTC
Agreed. The wording is confusing and we had some trouble with this very problem this weekend. Lisette Created attachment 90704 [details] [review] Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Hi Lisette and Benjamin, I've changed the message, hope that works for you! Created attachment 90866 [details] [review] Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Only thing that was a little off was the processing AFTER this, the check/uncheck doesn't disappear once the success message appears in the first column. But that is beyond the scope of this bug. Created attachment 90907 [details] [review] Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |