Description
Chris Cormack
2010-05-21 00:49:13 UTC
Is this bug still valid? There are still instances where this bug should be fixed. The first example, bibliographic records which have items attached, has been fixed with a javascript alert() explaining that the record still has items attached. I see three places where this needs to be fixed: - patron deletion - update child to adult patron - delete subscription Created attachment 22195 [details] [review] Bug 2310 - Delete grayed out w/out explanation With some staff client menus options are displayed as disabled when the logged in user doesn't have permission to perform that function. This patch adds Bootstrap tooltips to patron menu items with text explaining why they are disabled. To test, log in as a user who lacks permission to modify patrons or set permissions. Open a patron record in circulation or patrons. Hovering over renew, delete, and set permissions links (in the patron toolbar "More" menu) should trigger a tooltip with a brief explanation. Test the "Update child to adult patron" link by viewing an adult patron. A separate patch will address catalog menu items. OR -- we could hide the menu items altogether. We do this with toolbar buttons and global "More" menu items. Opinions? Hmm... Upon reflection, the reason we previously didn't consider the option of hiding menu options altogether was probably that the template couldn't handle the logic required to hide the whole "More" menu if no options were available. This I'm guessing is now moot, not least because the "export checked in barcodes" item isn't controlled by any permission. Created attachment 22419 [details] [review] Bug 2310 - Delete grayed out w/out explanation With some staff client menus options are displayed as disabled when the logged in user doesn't have permission to perform that function. This patch adds Bootstrap tooltips to patron menu items with text explaining why they are disabled. To test, log in as a user who lacks permission to modify patrons or set permissions. Open a patron record in circulation or patrons. Hovering over renew, delete, and set permissions links (in the patron toolbar "More" menu) should trigger a tooltip with a brief explanation. Test the "Update child to adult patron" link by viewing an adult patron. A separate patch will address catalog menu items. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Great design! Created attachment 22456 [details] [review] [PASSED QA] Bug 2310 - Delete grayed out w/out explanation With some staff client menus options are displayed as disabled when the logged in user doesn't have permission to perform that function. This patch adds Bootstrap tooltips to patron menu items with text explaining why they are disabled. To test, log in as a user who lacks permission to modify patrons or set permissions. Open a patron record in circulation or patrons. Hovering over renew, delete, and set permissions links (in the patron toolbar "More" menu) should trigger a tooltip with a brief explanation. Test the "Update child to adult patron" link by viewing an adult patron. A separate patch will address catalog menu items. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> New tooltip texts are translatable, patch passes all tests and QA script. Tested according to test plan in Chromium and Firefox. Pushed to master. Thanks, Owen! Comment on attachment 22456 [details] [review] [PASSED QA] Bug 2310 - Delete grayed out w/out explanation Looks like this bug is an omnibus, so obsoleting the patch that was pushed and setting back to assigned. Commit : 01c101a Bug 2310: display tooltips explaining why patron menu items are disabled Pushed to 3.14.x, will be in 3.14.1 This patch (display tooltips explaining why patron menu items are disabled) has been pushed to 3.12.x, will be in 3.12.9. Thanks Owen! Why is this bug assigned again ? (In reply to Fridolin SOMERS from comment #12) > Why is this bug assigned again ? See comment 9. (In reply to Galen Charlton from comment #13) > See comment 9. Ok, omnibus. Thanks. No movement here for a long time, can this omnibus be closed? |