Description
Heather
2019-06-13 20:35:48 UTC
I don't think we even deliver MARC21slim2OPACDetail.xsl with subfield i enabled/included at the present time. However, it is a valid subfield so it probably should be added (and display in the right place before subfield a) I'm wrong, we do deliver it in the 246 (it displays in square brackets -no idea if this is correct or not), and it is in the Default framework. It's not in the framework for the 730 though. Created attachment 102471 [details] [review] Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. I've moved subfield i in the 246 field to the start of the field, and kept the existing punctuation (square brackets). I've also added subfield i to the 730 field as it previously didn't display. This subfield is delivered in the BK framework (although hidden by default), but not delivered at all in the Default framework. I have no idea if the punctuation is correct for this field - I've enclosed it in square brackets to be the same as the 246 field. I think there should be no brackets as the field should end with a colon (:) added by the cataloger. There are exmaples in the library of congress documentation: http://www.loc.gov/marc/bibliographic/bd246.html It also states "Subfield $i precedes subfield $a at the beginning of the field.", so we are on the right track here. I agree completely with Katrin--there should be no square brackets. MARC21 documentation is in accordance with cataloging rules that reserve square brackets to indicate information supplied in the cataloging record that is NOT from the prescribed source of information, e.g., a title supplied by the cataloger, information from publisher's descriptions, etc. So having square brackets around the 246 $i information is confusing and nonsensical--the information in the 246 $i is a label describing the data from the item in the 246 $a, so the data in 246 $i should never be enclosed in square brackets. Likewise, there should be no square brackets in the display of the 730 $i. Could the square brackets please be removed? I'm so sorry that I didn't think to request that the square brackets in the display be removed in the first place--I realize now that it would have saved time. Created attachment 102773 [details] [review] Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. I've removed the square brackets now - please can you test it again? Many thanks! Created attachment 103494 [details] [review] Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Created attachment 104186 [details] [review] Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx David and Heather, this was bugging me too! Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |