| Summary: | Status AVAILABLE and ORDERED for suggestions are not translated in the templates | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> | 
| Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | claudie.tregouet, f.demians, hayleypelham, martin.renvoize, nick | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       19.11.00 
 | 
        
        Circulation function: | |
| Attachments: | 
              Bug 23123: Add missing suggestion status to template for translation
               Bug 23123: Add missing suggestion status to template for translation Bug 23123: Add missing suggestion status to template for translation  | 
      ||
| 
 
        
          Description
        
        
          Katrin Fischer
        
        
        
        
          2019-06-14 13:10:24 UTC
        
       
    ORDERED is missing as well. This part of the code looks incomplete as well: 506 <td> 507 [% IF ( suggestions_loo.ASKED ) %] 508 Pending 509 [% ELSIF ( suggestions_loo.ACCEPTED ) %] 510 Accepted 511 [% ELSIF ( suggestions_loo.ORDERED ) %] 512 Ordered 513 [% ELSIF ( suggestions_loo.REJECTED ) %] 514 Rejected 515 [% ELSIF ( suggestions_loo.CHECKED ) %] 516 Checked 517 [% ELSIF AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) %] 518 [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) | html %] 519 [% ELSE %] 520 Status unknown 521 [% END %] 522 523 [% IF ( suggestions_loo.reason ) %] 524 <br />([% suggestions_loo.reason | html %]) 525 [% END %] 526 </td> Created attachment 91514 [details] [review] Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Created attachment 93444 [details] [review] Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> Thank you, Claudie! Created attachment 93582 [details] [review] Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00  |