| Summary: | Typo in returns.tt prevents printing branchcode in transfer slips | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, lucas, m.de.rooy, mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.02
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22977 | ||
| Attachments: |
Bug 23140: Fix typo in branchcode parameters for print slip
Bug 23140: Fix typo in branchcode parameters for print slip Bug 23140: Fix typo in branchcode parameters for print slip |
||
|
Description
Nick Clemens (kidclamp)
2019-06-17 17:58:46 UTC
Created attachment 90686 [details] [review] Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Found that I didn't get an internal error with this applied. So, I just made this see also bug 23120. Created attachment 90710 [details] [review] Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 90876 [details] [review] Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.02 backported to 18.11.x for 18.11.08 |