|
Description
Owen Leonard
2019-06-18 16:39:07 UTC
+1 Created attachment 106337 [details] [review] Bug 23148: Replace Bridge icons with transparent PNG files This patch adds SVG versions of the Bridge item type icon set to misc/interface_customization/itemtypeimg/bridge. It adds some new icons, and updates some existing icons. All GIF versions of the icons are replaced with transparent PNG files. Icon changes: - English text has been removed from all icons - New icon for "Periodical," to differentiate from "Journal" - New icon, "Controller" for video games - New icon for "Laserdisk" to differentiate from "DVD" - New icon for "Kit" to differentiate from "Archive" - New icon, "Reference books." - Updated "badges" on "Juvenile book" and "Reserve book" to try to express the information without English-specific letters. Before applying the patch, update some item types or collection codes with Bridge icons. Apply the patch and run the database update process. - Open the advanced search page in the staff client and confirm that your item type or collection code icons were updated correctly. - Go to Administration -> Item types and edit an item type. - Check the "bridge" tab and confirm that the icon options look correct. Created attachment 106349 [details] [review] Bug 23148: Replace Bridge icons with transparent PNG files This patch adds SVG versions of the Bridge item type icon set to misc/interface_customization/itemtypeimg/bridge. It adds some new icons, and updates some existing icons. All GIF versions of the icons are replaced with transparent PNG files. Icon changes: - English text has been removed from all icons - New icon for "Periodical," to differentiate from "Journal" - New icon, "Controller" for video games - New icon for "Laserdisk" to differentiate from "DVD" - New icon for "Kit" to differentiate from "Archive" - New icon, "Reference books." - Updated "badges" on "Juvenile book" and "Reserve book" to try to express the information without English-specific letters. Before applying the patch, update some item types or collection codes with Bridge icons. Apply the patch and run the database update process. - Open the advanced search page in the staff client and confirm that your item type or collection code icons were updated correctly. - Go to Administration -> Item types and edit an item type. - Check the "bridge" tab and confirm that the icon options look correct. Created attachment 106350 [details] [review] Bug 23148: (follow-up) Replace gif files in the OPAC with pngs This patch removes the old gif files from the OPAC bridge set and replaces them with png files. Created attachment 106352 [details] [review] Bug 23148: Replace Bridge icons with transparent PNG files This patch adds SVG versions of the Bridge item type icon set to misc/interface_customization/itemtypeimg/bridge. It adds some new icons, and updates some existing icons. All GIF versions of the icons are replaced with transparent PNG files. Icon changes: - English text has been removed from all icons - New icon for "Periodical," to differentiate from "Journal" - New icon, "Controller" for video games - New icon for "Laserdisk" to differentiate from "DVD" - New icon for "Kit" to differentiate from "Archive" - New icon, "Reference books." - Updated "badges" on "Juvenile book" and "Reserve book" to try to express the information without English-specific letters. Before applying the patch, update some item types or collection codes with Bridge icons. Apply the patch and run the database update process. - Open the advanced search page in the staff client and confirm that your item type or collection code icons were updated correctly. - Go to Administration -> Item types and edit an item type. - Check the "bridge" tab and confirm that the icon options look correct. Signed-off-by: David Nind <david@davidnind.com> Created attachment 106353 [details] [review] Bug 23148: (follow-up) Replace gif files in the OPAC with pngs This patch removes the old gif files from the OPAC bridge set and replaces them with png files. Signed-off-by: David Nind <david@davidnind.com> Hi Owen, this works nicely, but we still have references to the .gif files in the installer sample data. Can you please fix those as well? Created attachment 106391 [details] [review] Bug 23148: (follow-up) Correct image paths in sample_itemtypes.yml Created attachment 106392 [details] [review] Bug 23148: (follow-up) Correct image paths in sample data and tests Created attachment 106483 [details] [review] Bug 23148: Replace Bridge icons with transparent PNG files This patch adds SVG versions of the Bridge item type icon set to misc/interface_customization/itemtypeimg/bridge. It adds some new icons, and updates some existing icons. All GIF versions of the icons are replaced with transparent PNG files. Icon changes: - English text has been removed from all icons - New icon for "Periodical," to differentiate from "Journal" - New icon, "Controller" for video games - New icon for "Laserdisk" to differentiate from "DVD" - New icon for "Kit" to differentiate from "Archive" - New icon, "Reference books." - Updated "badges" on "Juvenile book" and "Reserve book" to try to express the information without English-specific letters. Before applying the patch, update some item types or collection codes with Bridge icons. Apply the patch and run the database update process. - Open the advanced search page in the staff client and confirm that your item type or collection code icons were updated correctly. - Go to Administration -> Item types and edit an item type. - Check the "bridge" tab and confirm that the icon options look correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 106484 [details] [review] Bug 23148: (follow-up) Replace gif files in the OPAC with pngs This patch removes the old gif files from the OPAC bridge set and replaces them with png files. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 106485 [details] [review] Bug 23148: (follow-up) Correct image paths in sample data and tests Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 106486 [details] [review] Bug 23148: Fix bridge image paths in de-DE installer files Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x |