Summary: | koha_object[s]_class methods must be implemented when needed | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
19.11.00
|
Circulation function: | |
Attachments: |
Bug 23152: Add tests
Bug 23152: Implement koha_object[s]_class when needed Bug 23152: Add tests Bug 23152: Implement koha_object[s]_class when needed Bug 23152: Fix more pluralisation (and add tests) |
Description
Jonathan Druart
2019-06-19 02:41:53 UTC
Created attachment 90765 [details] [review] Bug 23152: Add tests Created attachment 90766 [details] [review] Bug 23152: Implement koha_object[s]_class when needed A simple use case is the ->get_from_storage (useful when writing tests) Test plan: Apply only the first patch and notice the test failures Apply the second patch and confirm the the tests are returning green Created attachment 90803 [details] [review] Bug 23152: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 90804 [details] [review] Bug 23152: Implement koha_object[s]_class when needed A simple use case is the ->get_from_storage (useful when writing tests) Test plan: Apply only the first patch and notice the test failures Apply the second patch and confirm the the tests are returning green Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is a bit of a no-brainer and something I've been meaning to get around to doing myself for a while. Going straight for PQA as the patch is trivial to read and the qa scripts don't complain. The test currently fails, but the reason is clear and it just warrants an RM followup on push to bring it up to date with the available classes at the time of push. Passing QA. (In reply to Martin Renvoize from comment #5) > This is a bit of a no-brainer I wrote a script ;) Nice work! Pushed to master for 19.11.00 I missed that the tests here don't actually test the koha_objects_class at all here.. would be good to get a test for that method too. Created attachment 91005 [details] [review] Bug 23152: Fix more pluralisation (and add tests) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed the last follow-up.. oops.. i missed this one for ages :S |