|
Description
Marcel de Rooy
2019-06-21 09:05:07 UTC
Created attachment 90880 [details] [review] Bug 23177: (QA follow-up) Move three subs from the middle to the top in Circulation.t Removed trailing comma for last sub too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 90881 [details] [review] Bug 23177: (QA follow-up) Move rollback to the end Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 90882 [details] [review] Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback This resolves: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) Removing unneeded subtest txn's. We should probably add them everywhere or just at global level. Test plan: With all three patches applied, run Circulation.t a few times. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> RM: Consider these three patches as QA follow-ups for 23103 Created attachment 90899 [details] [review] Bug 23177: (QA follow-up) Move three subs from the middle to the top in Circulation.t Removed trailing comma for last sub too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 90900 [details] [review] Bug 23177: (QA follow-up) Move rollback to the end Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 90901 [details] [review] Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback This resolves: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) Removing unneeded subtest txn's. We should probably add them everywhere or just at global level. Test plan: With all three patches applied, run Circulation.t a few times. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 90902 [details] [review] Bug 23177: (RM follow-up) Further test clarifications This patch makes a few minor improvements to Circulation.t 1) Adds a name to some of the scoped blocks by converting them to subtests. 2) Adds output messages to some tests where they were missing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.02 cant clean apply this patchset to 18.11.x, no backport. If it is needed please help me with a rebase Created attachment 92175 [details] [review] Bug 23177: [18.11.x] (QA follow-up) Move three subs from the middle to the top in Circulation.t Removed trailing comma for last sub too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 23177: (QA follow-up) Move rollback to the end Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback This resolves: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) Removing unneeded subtest txn's. We should probably add them everywhere or just at global level. Test plan: With all three patches applied, run Circulation.t a few times. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 23177: (RM follow-up) Further test clarifications This patch makes a few minor improvements to Circulation.t 1) Adds a name to some of the scoped blocks by converting them to subtests. 2) Adds output messages to some tests where they were missing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 23177: Rebase fixes Thanks Nick! backported to 18.11.x for 18.11.09 |