Summary: | Koha::Objects supports find_or_create without passing through the Koha::Object store method | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P1 - high | CC: | dcook, jonathan.druart, koha-bugs, kyle, m.de.rooy, martin.renvoize, testopia, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21761 | ||
Bug Blocks: |
Description
Martin Renvoize (ashimema)
2019-06-21 16:00:39 UTC
Should we remove Koha::Objects->find_or_create? There are very few occurrences so far. (In reply to Jonathan Druart from comment #1) > Should we remove Koha::Objects->find_or_create? > There are very few occurrences so far. I reckon that's the most pragmatic approach.. it won't be too onerous to split the calls in two.. that's what happens behind the scenes in dbic land anyway. However.. do we use any of the create_related or multi-create functionality of dbic? That uses the internal find_or_create behind te scenes inside dbic. > Should we remove Koha::Objects->find_or_create? > There are very few occurrences so far. There are still occurrences of find_or_create in the codebase, so I believe this hasn't been resolved yet.(In reply to Jonathan Druart from comment #1) |