Bug 23193

Summary: Make set_password.pl use Koha::Script
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Command-line UtilitiesAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas, robin
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.03
Bug Depends on: 17746, 22600    
Bug Blocks:    
Attachments: Bug 23193: Make set_password.pl use Koha::Script
Bug 23193: Make set_password.pl use Koha::Script
Bug 23193: Make set_password.pl use Koha::Script

Description Tomás Cohen Arazi 2019-06-24 13:26:49 UTC
It seems the original patch missed to add it (probably because Koha::Script wasn't there). Anyways, needs fixation.
Comment 1 Tomás Cohen Arazi 2019-06-24 13:28:19 UTC
Created attachment 90945 [details] [review]
Bug 23193: Make set_password.pl use Koha::Script

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Mark Tompsett 2019-06-24 14:57:09 UTC
Created attachment 90949 [details] [review]
Bug 23193: Make set_password.pl use Koha::Script

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Kyle M Hall 2019-06-28 12:08:49 UTC
Created attachment 91066 [details] [review]
Bug 23193: Make set_password.pl use Koha::Script

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Martin Renvoize 2019-06-28 13:30:34 UTC
Nice work!

Pushed to master for 19.11.00
Comment 5 Fridolin Somers 2019-07-25 11:46:16 UTC
Pushed to 19.05.x for 19.05.03
Comment 6 Lucas Gass 2019-07-26 14:45:09 UTC
missing dependency for 18.11.x, no backport.