| Summary: | Reindent tools/batch_record_modification.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Attachments: |
Bug 23196: Reindent tools/batch_record_modification.tt
Bug 23196: (follow-up) Add comments to highlight structure Bug 23196: Reindent tools/batch_record_modification.tt Bug 23196: (follow-up) Add comments to highlight structure Bug 23196: Reindent tools/batch_record_modification.tt Bug 23196: (follow-up) Add comments to highlight structure |
||
|
Description
Owen Leonard
2019-06-24 17:07:23 UTC
Created attachment 90965 [details] [review] Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Created attachment 90966 [details] [review] Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Created attachment 90972 [details] [review] Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 90973 [details] [review] Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> If the file is correctly indented, do we really need the comments? I've found them very helpful in the past. The issue probably is that it won't stay that way and in a big file it can really help orientation. (In reply to Jonathan Druart from comment #5) > If the file is correctly indented, do we really need the comments? I also find the comments helpful when viewing source in the browser. Created attachment 91036 [details] [review] Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 91037 [details] [review] Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 Refactoring with only spaces so I choose to backport in order to minimize future conflicts with master commits ;) tried to backport, but quite a few merge conflicts and since this is an enhancement I am choosing to skip for 18.11.x, no backport |