|
Description
Arthur Suzuki
2019-06-25 09:05:22 UTC
Created attachment 90982 [details] [review] Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref Test plan: 1/ set uppercasesurname to 'Do' 2/ register a new patron using the REST API with lowercase surname 3/ verify the surname is not saved in uppercase 4/ apply patch 5/ repeat 2 6/ verify the surname now is saved to uppercase Created attachment 90983 [details] [review] Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron In memberentry.pl uppercasesurname transform is applied both on patron creation and update (save || insert). Therefore I moved the transformation a bit earlier in Koha::Patron so that it's apply both in "AddMember" and "ModMember" Same test plan applies Created attachment 90996 [details] [review] Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref Test plan: 1/ set uppercasesurname to 'Do' 2/ register a new patron using the REST API with lowercase surname 3/ verify the surname is not saved in uppercase 4/ apply patch 5/ repeat 2 6/ verify the surname now is saved to uppercase Comment on attachment 90983 [details] [review] Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron I believe the second patch is a rebase. Created attachment 91170 [details] [review] Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref Test plan: 1/ set uppercasesurname to 'Do' 2/ register a new patron using the REST API with lowercase surname 3/ verify the surname is not saved in uppercase 4/ apply patch 5/ repeat 2 6/ verify the surname now is saved to uppercase Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 91171 [details] [review] Bug 23199: Added tests for Koha::Patron Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 91172 [details] [review] Bug 23199: (follow-up) Fix tab/space issues Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 91318 [details] [review] Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref Test plan: 1/ set uppercasesurname to 'Do' 2/ register a new patron using the REST API with lowercase surname 3/ verify the surname is not saved in uppercase 4/ apply patch 5/ repeat 2 6/ verify the surname now is saved to uppercase Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 91319 [details] [review] Bug 23199: Added tests for Koha::Patron Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 91320 [details] [review] Bug 23199: (follow-up) Fix tab/space issues Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |