| Summary: | Problems when adding multiple items to an order in acquisitions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Johanna Räisä <johanna.raisa> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, johanna.raisa, jonathan.druart, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00,21.11, 22.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 29239 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 23202: Problems when adding multiple items to an order in acquisitions
Bug 23202: Problems when adding multiple items to an order in acquisitions Bug 23202: Fix screen freeze when ordereing several items |
||
|
Description
Nick Clemens (kidclamp)
2019-06-25 11:25:46 UTC
Nothing in the logs? What is their barcode settings? We got this problem too. Seems that the dateaccessioned.pl plugin in items dateaccessioned field is creating this. It is a javascript problem the flatpickr structure prevents items to be cloned in additem.js file. I can take this bug and fix it. Hi Johanna, thx for this! Could it be related to bug 30975 somehow? (In reply to Katrin Fischer from comment #3) > Hi Johanna, thx for this! Could it be related to bug 30975 somehow? I think that is a different problem, more of Jquery behavior. In this bug the browser console gives this error: Uncaught TypeError: $(...).parent(...).attr(...) is undefined So with flatpickr datefield it doesn't find correct attribute to continue. I can replicate the issue, when the 'date acquired' is filled in. This gives the error every time on adding multiple items: Uncaught TypeError: $(...).parent(...).attr(...) is undefined Johanna, are you still working on a fix? (In reply to Katrin Fischer from comment #5) > I can replicate the issue, when the 'date acquired' is filled in. This gives > the error every time on adding multiple items: > > Uncaught TypeError: $(...).parent(...).attr(...) is undefined > > Johanna, are you still working on a fix? I'm on to it. Just came from summer vacation. (In reply to Johanna Räisä from comment #6) > (In reply to Katrin Fischer from comment #5) > > I can replicate the issue, when the 'date acquired' is filled in. This gives > > the error every time on adding multiple items: > > > > Uncaught TypeError: $(...).parent(...).attr(...) is undefined > > > > Johanna, are you still working on a fix? > > I'm on to it. Just came from summer vacation. Thx! Will try to test. Created attachment 138120 [details] [review] Bug 23202: Problems when adding multiple items to an order in acquisitions This patch fixes adding multiple items on order acquisitions 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. Ahh, forgot to change the status. Here you go! Created attachment 138395 [details] [review] Bug 23202: Problems when adding multiple items to an order in acquisitions This patch fixes adding multiple items on order acquisitions 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tried add multi when ordering, receiving and cataloguing, all good. Johanna, please have a look at https://wiki.koha-community.org/wiki/Commit_messages#Examples Most of the time the bug report title and the commit title must be different (what the bug is vs what the patch does). Created attachment 139244 [details] [review] Bug 23202: Fix screen freeze when ordereing several items This patch fixes adding multiple items on order acquisitions The error is: Uncaught TypeError: $(...).parent(...).attr(...) is undefined Test plan: 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: adjust commit title Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> This patch does not make the code more robust but it fixes the problem without introducing new regressions (hopefully!). Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 Thanks! Pushed to 21.11 for 21.11.12 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. *** Bug 32175 has been marked as a duplicate of this bug. *** |