Summary: | Ability to set default ratio in holds ratio report | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Hold requests | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | RESOLVED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrew, barbara.johnson, caroline.cyr-la-rose, emily.lamancusa, fridolin.somers, gmcharlt, lucas, philip.orr, rkuiper, sbrown |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/931 |
Text to go in the release notes: |
This patch adds the new system preference 'HoldRatioDefault' to allow setting a different default value for the holds ratio report found in Circulation -> Holds -> Hold ratios.
The default value for the new system preference is 3.
|
Version(s) released in: |
24.05.00
|
Circulation function: | |||
Attachments: |
Bug 23208: Add system preference HoldRatioDefault
Bug 23208: Add ability to set a default hold ratio value Bug 23208: perltidy Bug 23208: Add system preference HoldRatioDefault Bug 23208: Add ability to set a default hold ratio value Bug 23208: perltidy Bug 23208: Add system preference HoldRatioDefault Bug 23208: Add ability to set a default hold ratio value Bug 23208: perltidy |
Description
Kelly McElligott
2019-06-25 19:13:42 UTC
+1 +1 This would be so helpful. We use a higher ratio in order to better manage our budget. Having to change it every time (and make sure all staff know that they should be changing it) takes extra time. Maybe this could be a system preference instead of being hard coded. +1 Created attachment 161557 [details] [review] Bug 23208: Add system preference HoldRatioDefault Created attachment 161558 [details] [review] Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Created attachment 161559 [details] [review] Bug 23208: perltidy It is important to note that if you are testing this with k-t-d then SQL strict mode needs to be turned off in the koha-conf.xml file by making sure the this line is set like so: <strict_sql_modes>0</strict_sql_modes> Created attachment 161729 [details] [review] Bug 23208: Add system preference HoldRatioDefault Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Created attachment 161730 [details] [review] Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Created attachment 161731 [details] [review] Bug 23208: perltidy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Created attachment 161855 [details] [review] Bug 23208: Add system preference HoldRatioDefault Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 161856 [details] [review] Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 161857 [details] [review] Bug 23208: perltidy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> I squashed a typo fix into the perltidy patch. Otherwise, it looks good and passes the QA checks. This is a nice addition! The DB update was missing the "say". Please keep an eye on these :) Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x |