|
Description
Lucas Gass (lukeg)
2019-06-25 21:01:15 UTC
It's the expected behavior:
565 [% ELSIF ( loop.first ) %]
566 <span class="actions"><span id="login4tags">Log in to add tags.</span></span>
567 [% END # IF loggedinusername %]
From commit 4073b27c503f8192a144b4762e6ff5d40576627f
Wrap up Tags integration - add sysprefs for new installs.
Note that when the user is not logged in, the Tags input box/button will not display.
The user will see a message telling them to log in to add tags. However, in order to
keep the results display clean, the message will display only once, utilizing the loop
context variable "__first__". Useful stuff!
Created attachment 91945 [details] [review] Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. this patch only adds a link to the this patch adds a link but does not attempt to add the button to every search results. As Jonathon noted that would keep the results page very clean. Created attachment 91998 [details] [review] Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 91999 [details] [review] Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Created attachment 92512 [details] [review] Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 92513 [details] [review] Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 92518 [details] [review] Bug 23210: login4tags should be a link TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 92519 [details] [review] Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 92522 [details] [review] Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92523 [details] [review] Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Lucas Gass from comment #0) > If a non-authenticated user goes to the search results page they will only > see the login4tags (Log in to add tags ) text included with the first > result. This should be included with every result. This part is still not fixed - I've filed a new bug. Bug 23528 - Show 'log in to add tags' link on all search result entries Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 backported to 18.11.x for 18.11.10 |