| Summary: | Remove type attribute from script tags: Cataloging | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
19.11.00,19.05.03
|
Circulation function: | |
| Bug Depends on: | |||
| Bug Blocks: | 22956 | ||
| Attachments: |
Bug 23226: Remove type attribute from script tags: Cataloging
Bug 23226: Remove type attribute from script tags: Cataloging Bug 23226: Remove type attribute from script tags: Cataloging |
||
|
Description
Owen Leonard
2019-06-27 13:23:46 UTC
Created attachment 91053 [details] [review] Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from <script> tags one cataloging and one authorities template. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Cataloging -> Cataloging home page - Cataloging -> Cataloging home page -> Search results - Authorities -> New authority -> New from Z39.50/SRU Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Created attachment 91667 [details] [review] Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from <script> tags one cataloging and one authorities template. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Cataloging -> Cataloging home page - Cataloging -> Cataloging home page -> Search results - Authorities -> New authority -> New from Z39.50/SRU Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Created attachment 91809 [details] [review] Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from <script> tags one cataloging and one authorities template. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Cataloging -> Cataloging home page - Cataloging -> Cataloging home page -> Search results - Authorities -> New authority -> New from Z39.50/SRU Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.10 |