Summary: | opac-ISBDdetail.pl dies on invalid biblionumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | OPAC | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy, martin.renvoize, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
Circulation function: | |||
Bug Depends on: | 22696 | ||
Bug Blocks: | |||
Attachments: |
Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber
Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber Bug 23248: (QA follow-up) Consolidate 404s |
Description
Tomás Cohen Arazi (tcohen)
2019-07-01 18:51:17 UTC
Created attachment 91156 [details] [review] Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 91157 [details] [review] Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 91293 [details] [review] Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 91311 [details] [review] Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 91312 [details] [review] Bug 23248: (QA follow-up) Consolidate 404s Merging two conditions: biblionumber is empty or biblionumber cannot be found. This make the strange int($biblionumber) unneeded. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 missing dependencies, wont backport to 18.11.x |