Summary: | EDI Order line incorrectly terminated when it ends with a quoted apostrophe | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Acquisitions | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | emma.ternrud, fridolin.somers, hayleypelham, lucas |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
Attachments: |
Patch and test
Bug 23251 Correct formatting of IMD data ending in apostrophe Bug 23251: Correct formatting of IMD data ending in apostrophe Bug 23251: Correct formatting of IMD data ending in apostrophe |
Description
Colin Campbell
2019-07-02 09:48:56 UTC
Created attachment 91188 [details] [review] Patch and test To test apply the patch and tests should still pass including new test for correct behaviour when data ends with apostrophe Created attachment 91782 [details] [review] Bug 23251 Correct formatting of IMD data ending in apostrophe IMD text data may end in an apostrophe (e.g. dreamin' ) This was causing the segment to be incorrectly formatted as only the last character was checked, not the preceding character to check whether it was quoted add a test for this specific occurence Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 91783 [details] [review] Bug 23251: Correct formatting of IMD data ending in apostrophe IMD text data may end in an apostrophe (e.g. dreamin' ) This was causing the segment to be incorrectly formatted as only the last character was checked, not the preceding character to check whether it was quoted add a test for this specific occurence Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Hi Colin, I've signed off the patch, but have a look here at the guidelines for patches: https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages Namely, the commit message and the Bugzilla message should be the same, and the patch message should contain Bug XXXX: in the subject heading. Thanks for contributing! And do let me know if you have any questions about the above :) Created attachment 91814 [details] [review] Bug 23251: Correct formatting of IMD data ending in apostrophe IMD text data may end in an apostrophe (e.g. dreamin' ) This was causing the segment to be incorrectly formatted as only the last character was checked, not the preceding character to check whether it was quoted add a test for this specific occurence Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.10 |