|
Description
Nick Clemens (kidclamp)
2019-07-02 13:47:15 UTC
Created attachment 91996 [details] [review] Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Created attachment 91997 [details] [review] Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Created attachment 92034 [details] [review] Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 92035 [details] [review] Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 92194 [details] [review] Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 92195 [details] [review] Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I actually think the follow-up would have made a separate bug ;) Created attachment 92210 [details] [review] Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92211 [details] [review] Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 no backported needed for 18.11.x, missing dependency. |