| Summary: | RecordedBooks - notify patron of need to login / register to see availability | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, jzairo, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement makes the RBDigital Recorded Books subscription more discoverable to library patrons by adding a notice to the OPAC for patrons to register and login with RBDigital if they have not already done so.
|
Version(s) released in: |
20.05.00, 19.11.02
|
| Circulation function: | |||
| Attachments: |
Bug 23261: Add notice for login/registering to RBdigital results
Bug 23261: Add notice for login/registering to RBdigital results Bug 23261: Add notice for login/registering to RBdigital results Bug 23261: Add notice for login/registering to RBdigital results Bug 23261: (follow-up) Use logged_in_user and move test |
||
|
Description
Nick Clemens (kidclamp)
2019-07-03 19:11:22 UTC
Created attachment 91233 [details] [review] Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Created attachment 94773 [details] [review] Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Works as described. Screencast available at: https://drive.google.com/file/d/14y5GfGtpt4IUClkKmlnhkFPaSCfyMr2s/view Created attachment 96038 [details] [review] Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: I did not test this patch, trusting author and tester. Nick, it is better to use "logged_in_user" instead of other loggedin* variables, which should be remove in the future. Not blocker however, and did not want to amend a patch I am not able to test. Created attachment 96356 [details] [review] Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 96357 [details] [review] Bug 23261: (follow-up) Use logged_in_user and move test Nice work everyone! Pushed to master for 20.05 Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 (In reply to Joy Nelson from comment #10) > Pushed to 19.11.x branch for 19.11.02 Hi Joy, there was a RM follow-up that was not attach to this bug report: commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe Bug 23261: (RM follow-up) Add missing uri filter It will fix the failure for xt/find-missing-filters.t on 19.11 Thanks Jonathan. Last commit pushed to 19.11.x branch for 19.11.02 (In reply to Jonathan Druart from comment #11) > (In reply to Joy Nelson from comment #10) > > Pushed to 19.11.x branch for 19.11.02 > > Hi Joy, there was a RM follow-up that was not attach to this bug report: > commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe > Bug 23261: (RM follow-up) Add missing uri filter > It will fix the failure for xt/find-missing-filters.t on 19.11 enhancement will not be backported to 19.05.x series |