Bug 23266

Summary: Add to cart fires twice on shelf page
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: ListsAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, lucas, m.de.rooy, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.03
Attachments: Bug 23266: Add to cart fires twice on shelf page
Bug 23266: Add to cart fires twice on shelf page
Bug 23266: Add to cart fires twice on shelf page

Description Marcel de Rooy 2019-07-04 12:56:51 UTC
Simple fix: opac-bottom.inc should do the work not opac-shelves itself.
Comment 1 Marcel de Rooy 2019-07-04 12:59:28 UTC
Created attachment 91290 [details] [review]
Bug 23266: Add to cart fires twice on shelf page

Remove some duplicate functionality between opac-bottom and opac-shelves.

Test plan:
[1] Before this patch, add to cart from a shelf page. Observe that the
    basket count is incremented with 2.
[2] After this patch, it should be incremented with 1.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Martin Renvoize 2019-07-05 07:53:04 UTC
Created attachment 91321 [details] [review]
Bug 23266: Add to cart fires twice on shelf page

Remove some duplicate functionality between opac-bottom and opac-shelves.

Test plan:
[1] Before this patch, add to cart from a shelf page. Observe that the
    basket count is incremented with 2.
[2] After this patch, it should be incremented with 1.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2019-07-05 07:53:48 UTC
Simple fix that clarifies the code and corrects the issue. Signing off.
Comment 4 Katrin Fischer 2019-07-06 10:11:22 UTC
Created attachment 91391 [details] [review]
Bug 23266: Add to cart fires twice on shelf page

Remove some duplicate functionality between opac-bottom and opac-shelves.

Test plan:
[1] Before this patch, add to cart from a shelf page. Observe that the
    basket count is incremented with 2.
[2] After this patch, it should be incremented with 1.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Martin Renvoize 2019-07-15 11:22:26 UTC
Nice work!

Pushed to master for 19.11.00
Comment 6 Fridolin Somers 2019-07-30 06:08:57 UTC
Pushed to 19.05.x for 19.05.03
Comment 7 Lucas Gass 2019-08-06 16:54:28 UTC
backported to 18.11.x for 18.11.09