| Summary: | Restore actual cost input field on order page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, jzairo, lucas, maryse.simard, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
| Circulation function: | |||
| Bug Depends on: | 9775 | ||
| Bug Blocks: | 27203 | ||
| Attachments: |
Bug 23294: Show actual price when ordering
Bug 23294: Show actual price when ordering Bug 23294: Show actual price when ordering |
||
|
Description
Andrew Fuerste-Henry
2019-07-10 17:34:18 UTC
> Prior to 18.11, Total was derived from aqorders.unitprice, which reflected > the Actual Cost entered when receiving. Sorry, I was incorrect about this bit. Prior to 18.11, orders showed both budgeted total *and* actual cost. Actual cost was removed in Bug 9775. For what it's worth, see also Bug 23020, which is also about getting actual cost to be visible from the basket end of things. Bug 9775 removed this field as it didn't fit all workflows I propose we should restore it and make it easily hideable for those who don't want to see it. Standing order baskets allow modification of received orders and we have hidden information Created attachment 91540 [details] [review] Bug 23294: Show actual price when ordering To test: 1 - Have a basket 2 - Add an order 3 - Modify the order, note you cannot see the unitprice/Actual cost 4 - Apply patch 5 - Note it is there 6 - Add to IntranetUserCSS: .ordering_unitprice{ display:none; } 7 - Reload 8 - Note it is hidden Created attachment 91673 [details] [review] Bug 23294: Show actual price when ordering To test: 1 - Have a basket 2 - Add an order 3 - Modify the order, note you cannot see the unitprice/Actual cost 4 - Apply patch 5 - Note it is there 6 - Add to IntranetUserCSS: .ordering_unitprice{ display:none; } 7 - Reload 8 - Note it is hidden Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> I think the question was not about seeing, but if we want to be able to edit the value at this point in time. I notice that there is a difference in behaviour to before bug 9775 and with this patch now - the input field used to appear as readonly when the basket was closed. I have no strong opinion here - when the basket is closed we don't offer edit links, so the difference is only seen if you try a little harder. It might be useful in some cases. Created attachment 92358 [details] [review] Bug 23294: Show actual price when ordering To test: 1 - Have a basket 2 - Add an order 3 - Modify the order, note you cannot see the unitprice/Actual cost 4 - Apply patch 5 - Note it is there 6 - Add to IntranetUserCSS: .ordering_unitprice{ display:none; } 7 - Reload 8 - Note it is hidden Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I've rephrased this - it's not only for standing orders. Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 backported to 18.11.x for 18.11.10 |