Bug 23316

Summary: GetFine needs updating for bug 22521
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: fridolin.somers, lucas
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.03
Bug Depends on: 22521    
Bug Blocks:    
Attachments: Bug 23316: Follow-up for bug 22521 to fix GetFine
Bug 23316: Follow-up for bug 22521 to fix GetFine
Bug 23316: (follow-up) for bug 22521 to fix GetFine

Description Martin Renvoize 2019-07-15 14:04:59 UTC
It looks like a case was missed when we converted fine handling away from 'F' and 'FU' to using 'OVERDUE' and various status's.
Comment 1 Martin Renvoize 2019-07-15 14:07:58 UTC
Created attachment 91528 [details] [review]
Bug 23316: Follow-up for bug 22521 to fix GetFine

We changed the way we classify fines with bug 22521 but missed one
instance.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Chris Cormack 2019-07-25 21:44:34 UTC
Created attachment 91775 [details] [review]
Bug 23316: Follow-up for bug 22521 to fix GetFine

We changed the way we classify fines with bug 22521 but missed one
instance.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Nick Clemens 2019-07-26 11:33:43 UTC
Created attachment 91799 [details] [review]
Bug 23316: (follow-up) for bug 22521 to fix GetFine

We changed the way we classify fines with bug 22521 but missed one
instance.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Martin Renvoize 2019-07-26 15:19:32 UTC
Nice work!

Pushed to master for 19.11.00
Comment 5 Fridolin Somers 2019-08-09 12:38:22 UTC
Pushed to 19.05.x for 19.05.03
Comment 6 Lucas Gass 2019-09-03 20:44:43 UTC
missing dependencies for 18.11.x, no backport