Summary: | Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype` | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18930, 18936 | ||
Bug Blocks: |
Description
Martin Renvoize (ashimema)
2019-07-16 12:59:01 UTC
I think this is done on bug 18936: Koha/CirculationRules.pm 54 our $RULE_KINDS = { 55 refund => { 56 scope => [ 'branchcode' ], 57 default_value => 1, 58 }, Also this rule must not exist in the DB for different categories or itemtypes, you can only define it (via the interface) for different libraries. Good call.. lets close it. |