| Summary: | Clean up localization template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 23351: Clean up localization template
Looks good with in my tests. Bug 23351: Clean up localization template Bug 23351: Clean up localization template |
||
|
Description
Owen Leonard
2019-07-19 16:28:37 UTC
Created attachment 91853 [details] [review] Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. This will conflict with Bug 20307 but not too badly. I can make this dependent on 20307 if necessary. Created attachment 93356 [details] [review] Looks good with in my tests. Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. Created attachment 93450 [details] [review] Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93451 [details] [review] Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 |