Summary: | ACQ framework makes fr-CA web installer explode | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathben <mathben.informatique> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | major | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, gmcharlt, jonathan.druart, lucas, tomascohen |
Version: | 19.05 | ||
Hardware: | All | ||
OS: | Linux | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
Circulation function: | |||
Attachments: |
Bug 23353: ACQ framework makes fr-CA web installer explode
Bug 23353: ACQ framework makes fr-CA web installer explode Bug 23353: ACQ framework makes fr-CA web installer explode |
Description
Mathben
2019-07-22 03:28:37 UTC
I cannot reproduce this bug. What I did: - Run: $ mkdir test_koha $ vagrant init debian/stretch64 $ vim Vagrantfile <uncommented the private_network thing> $ vagrant up $ vagrant ssh $ wget -q -O- https://debian.koha-community.org/koha/gpg.asc | sudo apt-key add - $ echo 'deb http://debian.koha-community.org/koha 19.05 main' | sudo tee /etc/apt/sources.list.d/koha.list $ sudo apt update ; sudo apt install mysq-server koha-common $ sudo a2enmod rewrite $ sudo a2enmod cgi $ sudo systemctl restart apache2 $ sudo koha-create --create-db test $ sudo a2enmod headers proxy_http $ sudo systemctl restart apache2 $ sudo koha-plack --enable test $ sudo koah-plack --start test $ sudo koha-passwd test <copied the displayed password> - Tweaked my /etc/hosts adding 192.168.33.10 test-intra.myDNSname.org test.myDNSname.org - Pointed my browser to: http://test-intra.myDNSname.org - Used the instance credentials: koha_test / <the copied password> - Followed the steps, chose all the sample data => SUCCESS: No failures at all. I noticed this was about the fr-CA translation, and my tests fail on the very first step saying: Template process failed: file error - /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/fr-CA/modules/installer/step1.tt So, this is about the fr-CA translations! I have taken a look: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/fr-CA/marcflavour/marc21/obligatoire/marc21_sample_acq_framework.sql;h=f5131375d8d515508167a293fc8ca0f937e25bf0;hb=f9572dd1acd9f39229d8cd864050a536b9c2815d First it adds a copy of the default framework as the new ACQ framework with the first 3 INSERTS. Then the 4th tries to add a subset of the fields *again* which makes things explode. I didn't dare to just remove the one or the other set of INSERTS, because: - If you remove 4th and 5th the generated framework you have way too many fields visible if you decide to use the bibliographic part of it in ACQ (UseACQFrameworkForBiblioRecords) - If you remove the 2nd and 3rd, then you end up without 952 It appears that other installers don't have an ACQ framwork, at least I didn't spot one in en and de-DE. As a workaround for now: uncheck the ACQ framework from installing when you run the onboarding/web installer. Downgrading a bit, since the problem is limited and there is a workaoround. Looks like it was this commit: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=ad2b04001fe3100a5caeafbbdd5ea56a6ff65e1a Another note: 3 fr-CA files were amended - we only want one file to add the ACQ framework, not 3 :) (In reply to Katrin Fischer from comment #5) > Another note: 3 fr-CA files were amended - we only want one file to add the > ACQ framework, not 3 :) Dismiss this comment, got confused by fr-FR and fr-CA and marcflavours. I will clean up the sql files for fr-CA Created attachment 92297 [details] [review] Bug 23353: ACQ framework makes fr-CA web installer explode This patch removes the standalone ACQ framework SQL file in the fr-CA directory and adds the ACQ framework creation SQL in the default framework file, as it is in other languages. Created attachment 92625 [details] [review] Bug 23353: ACQ framework makes fr-CA web installer explode This patch removes the standalone ACQ framework SQL file in the fr-CA directory and adds the ACQ framework creation SQL in the default framework file, as it is in other languages. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 92653 [details] [review] Bug 23353: ACQ framework makes fr-CA web installer explode This patch removes the standalone ACQ framework SQL file in the fr-CA directory and adds the ACQ framework creation SQL in the default framework file, as it is in other languages. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 backported to 18.11.x for 18.11.11 |