| Summary: | Cache ClassSource | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Ian Walls <ian> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | lucas, martin.renvoize, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 23387: Add caching to C4::ClassSource
Bug 23387: Add caching to C4::ClassSource Bug 23387: Add caching to C4::ClassSource |
||
|
Description
Ian Walls
2019-07-26 15:39:44 UTC
Still valid? Created attachment 170076 [details] [review] Bug 23387: Add caching to C4::ClassSource These routines ultimately need to be moved to the Koha namespace, for now though, we can reduce look ups during import and batch modification by caching the values here for each request To test: 1 - prove -v t/db_dependent/ClassSources.t 2 - Import some records with items, confirm cn_sort values correctly built 3 - Edit some items, confirm cn_Sort correclty built (In reply to Katrin Fischer from comment #1) > Still valid? Yes, when migrating a library we noticed repeated lookups in the class sources tables from bulkmarcimport We should go further and move to these to Koha namespace and cache at a deeper level, however, this will offer a benefit now and is a minor change Created attachment 170659 [details] [review] Bug 23387: Add caching to C4::ClassSource These routines ultimately need to be moved to the Koha namespace, for now though, we can reduce look ups during import and batch modification by caching the values here for each request To test: 1 - prove -v t/db_dependent/ClassSources.t 2 - Import some records with items, confirm cn_sort values correctly built 3 - Edit some items, confirm cn_Sort correclty built Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 170685 [details] [review] Bug 23387: Add caching to C4::ClassSource These routines ultimately need to be moved to the Koha namespace, for now though, we can reduce look ups during import and batch modification by caching the values here for each request To test: 1 - prove -v t/db_dependent/ClassSources.t 2 - Import some records with items, confirm cn_sort values correctly built 3 - Edit some items, confirm cn_Sort correclty built Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Clear code, well tested, noticeable improvement. Passing QA Pushed for 24.11! Well done everyone, thank you! |