Summary: | Support MARC21 indicators for private note fields | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | OPAC | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | mkstephens |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
Attachments: |
Bug 23392: Don;t display private notes in MARC 21
Bug 23392: Don;t display private notes in MARC 21 Bug 23838: Add 'renewals' API route Bug 23838: Add renewals modal Bug 23392: Don;t display private notes in MARC 21 |
Description
Nick Clemens
2019-07-29 13:20:08 UTC
Created attachment 91851 [details] [review] Bug 23392: Don;t display private notes in MARC 21 To test: 1 - Add some notes to a record in fields 541,542,561,583,590 2 - Ensure all of these are visible in the frameworks 3 - Note they appear in the 'Title notes'/'Description' tabs on OPAC/Staff client 4 - Mark first indicator '0' on all notes 5 - They still display 6 - Apply patch 7 - Notes no longer show on OPAC 8 - Notes still show on Staff client 9 - prove -v t/Biblio/GetMarcNotes.t Passed test. Works as expected. Created attachment 94632 [details] [review] Bug 23392: Don;t display private notes in MARC 21 To test: 1 - Add some notes to a record in fields 541,542,561,583,590 2 - Ensure all of these are visible in the frameworks 3 - Note they appear in the 'Title notes'/'Description' tabs on OPAC/Staff client 4 - Mark first indicator '0' on all notes 5 - They still display 6 - Apply patch 7 - Notes no longer show on OPAC 8 - Notes still show on Staff client 9 - prove -v t/Biblio/GetMarcNotes.t Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Created attachment 94633 [details] [review] Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Created attachment 94634 [details] [review] Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Comment on attachment 94632 [details] [review] Bug 23392: Don;t display private notes in MARC 21 Review of attachment 94632 [details] [review]: ----------------------------------------------------------------- ::: Koha/Cache.pm @@ +249,4 @@ > ? $set_sub->( $key, $value ) > : $self->{$cache}->set( $key, $value ); > } > + warn $expiry; Should be removed - I'll amend the patch. Created attachment 94642 [details] [review] Bug 23392: Don;t display private notes in MARC 21 To test: 1 - Add some notes to a record in fields 541,542,561,583,590 2 - Ensure all of these are visible in the frameworks 3 - Note they appear in the 'Title notes'/'Description' tabs on OPAC/Staff client 4 - Mark first indicator '0' on all notes 5 - They still display 6 - Apply patch 7 - Notes no longer show on OPAC 8 - Notes still show on Staff client 9 - prove -v t/Biblio/GetMarcNotes.t Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 |