Summary: | Exporting/Reimporting frameworks in XML format will give incomplete results | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, m.de.rooy, martin.renvoize, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
19.11.00,19.05.05
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 23892 | ||
Attachments: |
Bug 23398: Disable the XML import/export format for biblio framework
Bug 23398: Disable the XML import/export format for biblio framework Bug 23398: Disable the XML import/export format for biblio framework |
Description
Katrin Fischer
2019-07-29 19:04:42 UTC
Is this a regression or it never worked? Note: I exported the default framework, the import process is broken: 020 is the first non imported field and it is in the generated .xml file. CSV is ok I am not sure, we've always used the OpenDocument format, so I have never run into this so far. Why does this not show up on the dashboard with the other criticals? (In reply to Katrin Fischer from comment #3) > Why does this not show up on the dashboard with the other criticals? We display the bug reports created in the last 60 days if the status is NEW, ASSIGNED, In disussion, FQA or does not apply. (In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #3) > > Why does this not show up on the dashboard with the other criticals? > > We display the bug reports created in the last 60 days if the status is NEW, > ASSIGNED, In disussion, FQA or does not apply. Didn't know about the last 60 days... guess the situation si worse than I thought it is! Created attachment 94687 [details] [review] Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Created attachment 95161 [details] [review] Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Code scans well and does what is expected. I agree to the pragmatic decision of just removing the option at this point too. Signing off. Created attachment 95179 [details] [review] Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.05 |