Summary: | Circulation autocomplete for patron lookup broken if cardnumber is empty | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, lucas, maryse.simard, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03,18.11.09
|
|
Bug Depends on: | |||
Bug Blocks: | 23518 | ||
Attachments: |
Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty
Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty |
Description
Owen Leonard
2019-07-31 15:25:45 UTC
Created attachment 91894 [details] [review] Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Created attachment 91939 [details] [review] Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 91940 [details] [review] Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Ian Walls <ian@bywatersolutions.com> Created attachment 92041 [details] [review] Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Ian Walls <ian@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |