| Summary: | When a note to a specific issue upon receiving a serial, this note will appear in next issue received | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kelly McElligott <kelly> |
| Component: | Serials | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, marjorie.barry-vila, maryse.simard, nadine.pierre, nick, severine.queune |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
| Circulation function: | |||
| Bug Depends on: | 11492 | ||
| Bug Blocks: | |||
| Attachments: |
serials receive
Bug 23416: Add PreserveSerialNotes system preference Bug 23416: Add PreserveSerialNotes system preference Bug 23416: Add PreserveSerialNotes system preference Bug 23416: Add PreserveSerialNotes system preference Bug 23416: (QA follow-up) Add IGNORE to updatedatabase SQL statement |
||
Wondering if this could be related to the notes work on bug 11492? Created attachment 91929 [details] [review] Bug 23416: Add PreserveSerialNotes system preference Bug 11492 intended to pass routinglists forward. It also passed forward serial notes. This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref to control this behaviour. To test: 1 - Have or create a subscription in the serials module 2 - Recieve an issue, making sure ot ad a note 3 - Go to receive again, note the note from the last serial is set for the expected issue 4 - Apply patch 5 - Update database, restart all the things 6 - Receive the issue leaving the note in place 7 - Note the next expected issue has the note 8 - Find the syspref PreserveSerialNotes 9 - Confirm it defaulted to Do 10 - Set it to 'Do not' 11 - Receive the expected serial leavign the note 12 - Note the newly generated expected serial has no note 13 - prove -v t/db_dependent/Serials.t Created attachment 91932 [details] [review] Bug 23416: Add PreserveSerialNotes system preference Bug 11492 intended to pass routinglists forward. It also passed forward serial notes. This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref to control this behaviour. To test: 1 - Have or create a subscription in the serials module 2 - Recieve an issue, making sure ot ad a note 3 - Go to receive again, note the note from the last serial is set for the expected issue 4 - Apply patch 5 - Update database, restart all the things 6 - Receive the issue leaving the note in place 7 - Note the next expected issue has the note 8 - Find the syspref PreserveSerialNotes 9 - Confirm it defaulted to Do 10 - Set it to 'Do not' 11 - Receive the expected serial leavign the note 12 - Note the newly generated expected serial has no note 13 - prove -v t/db_dependent/Serials.t Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Created attachment 91934 [details] [review] Bug 23416: Add PreserveSerialNotes system preference Bug 11492 intended to pass routinglists forward. It also passed forward serial notes. This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref to control this behaviour. To test: 1 - Have or create a subscription in the serials module 2 - Recieve an issue, making sure ot ad a note 3 - Go to receive again, note the note from the last serial is set for the expected issue 4 - Apply patch 5 - Update database, restart all the things 6 - Receive the issue leaving the note in place 7 - Note the next expected issue has the note 8 - Find the syspref PreserveSerialNotes 9 - Confirm it defaulted to Do 10 - Set it to 'Do not' 11 - Receive the expected serial leavign the note 12 - Note the newly generated expected serial has no note 13 - prove -v t/db_dependent/Serials.t Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 92098 [details] [review] Bug 23416: Add PreserveSerialNotes system preference Bug 11492 intended to pass routinglists forward. It also passed forward serial notes. This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref to control this behaviour. To test: 1 - Have or create a subscription in the serials module 2 - Recieve an issue, making sure ot ad a note 3 - Go to receive again, note the note from the last serial is set for the expected issue 4 - Apply patch 5 - Update database, restart all the things 6 - Receive the issue leaving the note in place 7 - Note the next expected issue has the note 8 - Find the syspref PreserveSerialNotes 9 - Confirm it defaulted to Do 10 - Set it to 'Do not' 11 - Receive the expected serial leavign the note 12 - Note the newly generated expected serial has no note 13 - prove -v t/db_dependent/Serials.t Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92099 [details] [review] Bug 23416: (QA follow-up) Add IGNORE to updatedatabase SQL statement I am ok with this fix, but I'd suggest to pick 'not prefill' for new installations. My feeling is that this will be the more common setting. Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 Back in Master 20.12.00.023 : https://snipboard.io/xwKPoX.jpg (In reply to Séverine Queune from comment #10) > Back in Master 20.12.00.023 : https://snipboard.io/xwKPoX.jpg Hi Severine, have you checked your setting for PreserveSerialNotes ? #shameonme... Thanks Cate ! It seems I should not test Serials so early in the morning... Sorry for trolling the patch :/ |
Created attachment 91920 [details] serials receive A note added to a serial issue upon receipt in the Serials module will stay on each upcoming issue expected and needs to be removed when receiving the next. Libraries use this note to say something specific about the issue they are receiving, not a note that should appear on every issue they receive. Steps to reproduce: 1. Receive an issue in the Serials Module. 2. Add a note to this issue and change to Arrived. 3. See the next expected issue will show this same note from previously received issue. 4. Receive next issue, this note is still getting generated.